Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #38

Merged
merged 10 commits into from
Aug 29, 2024
Merged

Bump versions #38

merged 10 commits into from
Aug 29, 2024

Conversation

oerc0122
Copy link
Collaborator

@oerc0122 oerc0122 commented Jul 12, 2024

Ensures CI builds work again by:

  • Refactor/clean create_mltbx.py
  • Updates versions of CI "actions" to latest (using Node.js 20)
  • Updates code to account for changes in Matlab between R2021b and R2024a
  • Updates ReadTheDocs configuration.

Copy link
Contributor

github-actions bot commented Jul 12, 2024

Test Results

3 files  ±0  3 suites  ±0   10s ⏱️ +4s
1 tests ±0  1 ✅ +1  0 💤 ±0  0 ❌ ±0 
3 runs  ±0  3 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit e1c990e. ± Comparison against base commit 30bcce9.

♻️ This comment has been updated with latest results.

@oerc0122 oerc0122 force-pushed the fix-gha-tests branch 13 times, most recently from 18037a5 to 2483f4c Compare July 16, 2024 14:24
* Fix DuplicateSuperClass error
* Fix helpwin.xsl path change
* Add check for empty module in install_python_mod to return early
Copy link
Collaborator Author

@oerc0122 oerc0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my gripes, all looks good

if not os.path.isfile(req_file):
from update_dependencies import update_submodules
update_submodules('euphonic_sqw_models')
for submodule in [['light_python_wrapper', '+light_python_wrapper'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh, os.path...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with that... I don't like to divide my paths...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> Path() / 0
ZeroDivisionError: division by zero

oh no!

@mducle mducle merged commit 79dcf97 into master Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants