-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions #38
Bump versions #38
Conversation
18037a5
to
2483f4c
Compare
* Fix DuplicateSuperClass error * Fix helpwin.xsl path change * Add check for empty module in install_python_mod to return early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my gripes, all looks good
if not os.path.isfile(req_file): | ||
from update_dependencies import update_submodules | ||
update_submodules('euphonic_sqw_models') | ||
for submodule in [['light_python_wrapper', '+light_python_wrapper'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh, os.path
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong with that... I don't like to divide my paths...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> Path() / 0
ZeroDivisionError: division by zero
oh no!
Ensures CI builds work again by:
create_mltbx.py